Jennyf/netcore5 #213
Merged
Jennyf/netcore5 #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
approved these changes
Jun 17, 2020
bgavrilMS
reviewed
Jun 17, 2020
| @@ -5,6 +5,6 @@ steps: | |||
| - task: UseDotNet@2 | |||
| displayName: 'Use .Net Core SDK' | |||
| inputs: | |||
| version: 3.1.101, 5.0.100-preview.5.20279.10 | |||
| version: 5.0.100-preview.5.20279.10 | |||
There was a problem hiding this comment.
yeah, I was suprised that you can have a list there :)
There was a problem hiding this comment.
that's what the documentation says to do. idk. doesn't seem to work.
There was a problem hiding this comment.
@bgavrilMS had to make separate tasks for each TFW
jennyf19
force-pushed
the
jennyf/netcore5
branch
from
62b3e46
to
4af9b33
Compare
|
@jmprieur this is ready now. will need to update the release build when the time comes to .net 5 |
jmprieur
approved these changes
Jun 17, 2020
jennyf19
commented
Jun 17, 2020
| var configuredJwtOptions = provider.GetService<IConfigureOptions<JwtBearerOptions>>() as ConfigureNamedOptions<JwtBearerOptions>; | ||
|
|
||
| Assert.Equal(_jwtBearerScheme, configuredJwtOptions.Name); | ||
| var configuredJwtOptions = provider.GetService<IConfigureOptions<JwtBearerOptions>>() as IConfigureNamedOptions<JwtBearerOptions>; |
There was a problem hiding this comment.
- This is an issue w/.NET 5, it's a
ConfigureNamedOptions<JwtBearerOptions, Microsoft.AspNetCore.Authentication.JwtBearer>, which is not aConfigureNamedOptions<JwtBearerOptions>. and, Microsoft.AspNetCore.Authentication.JwtBeareris not a public type.
x.GetType().FullName
"Microsoft.Extensions.Options.ConfigureNamedOptions`2[[Microsoft.AspNetCore.Authentication.JwtBearer.JwtBearerOptions, Microsoft.AspNetCore.Authentication.JwtBearer, Version=5.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60],[System.IServiceProvider, System.ComponentModel, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]]" We probably don't need to check the name, this isn't surfaced by the interface.
jennyf19
added a commit
that referenced
this pull request
Jun 17, 2020
* initial commit for net core 5 * update dependencies
jennyf19
added a commit
that referenced
this pull request
Jun 17, 2020
* Initial work (does not build) * fix tests (#205) move files to migrationaid folder * AddMicrosoftWebAppCallsApi naming changes (#208) * AddMicrosoftWebAppCallsApi naming changes * fix xml comments * more changes to api surface (#210) * more changes to api surface * fix namespace * add services obsolete file and fix namespace * Fixing one of the samples Co-authored-by: Jean-Marc Prieur <[email protected]> * Jennyf/netcore5 (#213) * initial commit for net core 5 * update dependencies * Proposing to also remove the token decrypt certificate from AddMicrosoftWebAPI (#212) * more changes to api surface * fix namespace * add services obsolete file and fix namespace * Fixing one of the samples proposing to also remove the certificate from the public API of AddMicrosoftProtectedApi. something like the following. * Improving the experience of the MigrationAid when calling AddProtectedWebApi (obsolete), with a decrypt certificate. Updating the tests Co-authored-by: Jenny Ferries <[email protected]> * Initial work (does not build) * fix tests (#205) move files to migrationaid folder * AddMicrosoftWebAppCallsApi naming changes (#208) * AddMicrosoftWebAppCallsApi naming changes * fix xml comments * more changes to api surface (#210) * more changes to api surface * fix namespace * add services obsolete file and fix namespace * Fixing one of the samples Co-authored-by: Jean-Marc Prieur <[email protected]> * Jennyf/netcore5 (#213) * initial commit for net core 5 * update dependencies * Proposing to also remove the token decrypt certificate from AddMicrosoftWebAPI (#212) * more changes to api surface * fix namespace * add services obsolete file and fix namespace * Fixing one of the samples proposing to also remove the certificate from the public API of AddMicrosoftProtectedApi. something like the following. * Improving the experience of the MigrationAid when calling AddProtectedWebApi (obsolete), with a decrypt certificate. Updating the tests Co-authored-by: Jenny Ferries <[email protected]> * Update template-install-dotnet-core.yaml Co-authored-by: Jean-Marc Prieur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jmprieur